Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): derived atom is not re-evaluated if it read between multiple set #2960

Merged
merged 4 commits into from
Jan 31, 2025
Merged

fix(core): derived atom is not re-evaluated if it read between multiple set #2960

merged 4 commits into from
Jan 31, 2025

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 27, 2025

close #2959

@vercel Vercel
Copy link

vercel bot commented Jan 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 0:23am

@dai-shi dai-shi marked this pull request as draft January 27, 2025 15:15
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 27, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 27, 2025 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@2960

commit: 5f650b8

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Size Change: -29 B (-0.03%)

Total Size: 92.1 kB

Filename Size Change
./dist/esm/vanilla.mjs 4.21 kB -1 B (-0.02%)
./dist/system/vanilla.development.js 4.3 kB -4 B (-0.09%)
./dist/system/vanilla.production.js 2.18 kB -8 B (-0.37%)
./dist/umd/vanilla.development.js 5.7 kB -6 B (-0.11%)
./dist/umd/vanilla.production.js 2.85 kB -6 B (-0.21%)
./dist/vanilla.js 5.58 kB -4 B (-0.07%)
ℹ️ View Unchanged
Filename Size
./dist/babel/plugin-debug-label.js 933 B
./dist/babel/plugin-react-refresh.js 1.14 kB
./dist/babel/preset.js 1.41 kB
./dist/esm/babel/plugin-debug-label.mjs 1 kB
./dist/esm/babel/plugin-react-refresh.mjs 1.2 kB
./dist/esm/babel/preset.mjs 1.49 kB
./dist/esm/index.mjs 62 B
./dist/esm/react.mjs 1.41 kB
./dist/esm/react/utils.mjs 747 B
./dist/esm/utils.mjs 67 B
./dist/esm/vanilla/utils.mjs 5.05 kB
./dist/index.js 242 B
./dist/react.js 1.44 kB
./dist/react/utils.js 1.39 kB
./dist/system/babel/plugin-debug-label.development.js 1.11 kB
./dist/system/babel/plugin-debug-label.production.js 775 B
./dist/system/babel/plugin-react-refresh.development.js 1.3 kB
./dist/system/babel/plugin-react-refresh.production.js 928 B
./dist/system/babel/preset.development.js 1.59 kB
./dist/system/babel/preset.production.js 1.14 kB
./dist/system/index.development.js 252 B
./dist/system/index.production.js 183 B
./dist/system/react.development.js 1.56 kB
./dist/system/react.production.js 865 B
./dist/system/react/utils.development.js 859 B
./dist/system/react/utils.production.js 462 B
./dist/system/utils.development.js 257 B
./dist/system/utils.production.js 187 B
./dist/system/vanilla/utils.development.js 5.26 kB
./dist/system/vanilla/utils.production.js 3.15 kB
./dist/umd/babel/plugin-debug-label.development.js 1.07 kB
./dist/umd/babel/plugin-debug-label.production.js 852 B
./dist/umd/babel/plugin-react-refresh.development.js 1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js 1 kB
./dist/umd/babel/preset.development.js 1.54 kB
./dist/umd/babel/preset.production.js 1.22 kB
./dist/umd/index.development.js 383 B
./dist/umd/index.production.js 328 B
./dist/umd/react.development.js 1.56 kB
./dist/umd/react.production.js 936 B
./dist/umd/react/utils.development.js 1.53 kB
./dist/umd/react/utils.production.js 1.01 kB
./dist/umd/utils.development.js 399 B
./dist/umd/utils.production.js 342 B
./dist/umd/vanilla/utils.development.js 6.25 kB
./dist/umd/vanilla/utils.production.js 3.78 kB
./dist/utils.js 247 B
./dist/vanilla/utils.js 6.11 kB

compressed-size-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

LiveCodes Preview in LiveCodes

Latest commit: 5f650b8
Last updated: Jan 31, 2025 12:22am (UTC)

Playground Link
React demo https://livecodes.io?x=id/BV5YW7H8H

See documentations for usage instructions.

@dai-shi dai-shi marked this pull request as ready for review January 27, 2025 15:20
@dai-shi dai-shi added this to the v2.11.2 milestone Jan 31, 2025
@dai-shi dai-shi merged commit 1a2bbb5 into main Jan 31, 2025
45 checks passed
@dai-shi dai-shi deleted the issue-2959 branch January 31, 2025 00:36
dmaskasky pushed a commit to dmaskasky/jotai that referenced this pull request Feb 3, 2025
@dai-shi @dmaskasky
fix(core): derived atom is not re-evaluated if it read between multip…
97412c5 
…le set (pmndrs#2960)

* add failing test

* fix it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.11.2
Development

Successfully merging this pull request may close these issues.
1 participant
@dai-shi